Sayali: dark mode background for Reports People page#5015
Sayali: dark mode background for Reports People page#5015one-community merged 3 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
one-community
added
the
High Priority - Please Review First
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sayali,
I have reviewed your PR locally. Most of the dark mode fixes are working correctly. However, I noticed a couple of issues that I believe fall under the scope of this PR:
- The "Total Hours" text is not styled correctly in dark mode.
- The "Clear Filters" button is not styled correctly in dark mode.
Could you confirm if these fall under the scope of this PR?
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Sayali,
I have reviewed your PR locally and though dark mode is applied to most components. The below require your fix:
- The Total hours text is not well adapted to dark mode
- The toggle is not visible in dark mode
- The Clear Filters text is not well adapted to dark mode
- The graphs axis is not visible in dark mode
|
Hi @HemanthNidamanuru and @Anusha-Gali thank you for the thorough review! |
Please fix the rest of the requests on this, those are all darkmode issues so I consider them “in scope” and not something I want to create a new task for |
|
|
Hi @HemanthNidamanuru and @Anusha-Gali thank you for the detailed feedback!
|
rajanidi1999
left a comment
rajanidi1999
left a comment
There was a problem hiding this comment.
Hi,
I have reviewed your PR locally. Most of the dark mode fixes are working correctly.
There was a problem hiding this comment.
Hi @Anusha-Gali
The .text-light .table-filter-item rule in TableFilter.css was pre-existing and not part of my changes. My PR only touches the files listed above. The Clear Filters styling issue is out of scope for this task
rithika-paii
left a comment
rithika-paii
left a comment
There was a problem hiding this comment.
Hi Sayali,
I reviewed PR#5015 and tested it locally; all the changes are implemented and look good from my end.
|
Thank you all, merging! Will make the remaining bits a new task. |
6 participants
Description
Fixes Reports People page dark mode background issue (Priority Medium)
The Reports → People page had incorrect background colors in dark mode. This PR fixes the background styling across all components of the People report page.
Related PRS (if any):
None (standalone fix)
Main changes explained:
How to test:
Screenshots or videos of changes:
Note:
This is a frontend-only change focusing on the Reports People page and individual person report view. The fix uses CSS modules to avoid conflicts with other pages.